disable auto js extensions #219

guybedford · 2014-09-24T21:00:10Z

Here's a prototype for #218.

In normalize, we normalize relative to the parentName, and when none is provided we normalize relative to the baseURL.
Paths are applied in normalize, before normalization, only on names that do not start with "scheme:", "./", "../", "/".
Locate does a final normalization relative to the baseURL

All tests passing.

Feedback welcome @caridy.

guybedford · 2014-09-24T21:01:56Z

Note most of this is tests. The only logic changes are in the system.js file at https://github.com/ModuleLoader/es6-module-loader/pull/219/files#diff-6387cea082f6e735c8c1d75728d615b6L127.

caridy · 2014-09-28T17:15:30Z

LGTM

guybedford · 2014-09-30T12:02:09Z

src/system.js

+      // it is possible for locate to not to be a fully normalized URL
+      // if name was forced into not being of an absolute URL by normalize
+      // so we run toAbsoluteURL again just in case
+      return toAbsoluteURL(this.baseURL, load.name);


Alternatively, we could throw here if load.name was not already absolute?

yeah, I think we should throw, or just go with whatever we get blindly

Actually this would mess up all uses of names like @system, @traceur. Or should these become schema names anyway?

guybedford · 2014-09-30T16:25:08Z

Another question - in NodeJS, /Users/etc/.... is not a valid module name because it should be written - file:/Users/etc/... right?

caridy · 2014-09-30T16:32:14Z

no, I think / or C:\ are just find, they are absolute paths in the filesystem. Why are you asking?

guybedford · 2014-09-30T16:34:09Z

Because / is still not a fully-normalized URI right, as in missing the schema?

Or is the absolute URI check just /^\/|:/?

caridy · 2014-09-30T18:51:48Z

well, my doc is only covering the browser side of it, ideally I will have time next week to work on the nodejs version of it, but I think on the nodejs runtime things are different, and the concept of URI is not longer valid since nodejs doesn't know about those.

guybedford · 2014-10-01T10:26:35Z

Thanks... would be really appreciated. That's why I assumed a file: schema in Node like how browsers handle file paths.

guybedford · 2014-10-01T12:51:44Z

The latest commit includes the throwing behaviour with the file: addition in Node (all tests passing).

caridy · 2014-10-01T14:30:05Z

LGTM

guybedford · 2014-10-01T14:31:12Z

Great, thanks.

arv · 2014-10-03T14:33:46Z

test/test.js

@@ -88,7 +88,7 @@ function runTests() {
  var oldBaseURL = System.baseURL;
  System.baseURL = 'http://example.org/a/b.html';

-  test('Normalize - No Referer', System.normalize('d/e/f'), 'd/e/f');
+  test('Normalize - No Referer', System.normalize('d/e/f'), 'http://example.org/a/d/e/f');


I thought the idea was that if it doesn't start with './' etc then it should do no normalization?

Meaning, that the only way to load these would be to first register them.

good catch @arv, that's indeed the idea. if there is no d/* pattern, it should throw.

So we expect all local paths to be loaded with ./?

Eg:

<script type="module"> import "./app.js" </script>

works by requesting relative to the baseURL, but app.js does not?

I believe this test should be:

test('Normalize - No Referer', System.normalize('d/e/f'), 'd/e/f');

The idea here was that paths would apply to these sorts of names to make them work, eg:

System.paths['d/*'] = 'http://site.com/path/*';

And if there was no path match, we can't fetch it?

We currently throw in locate if this was the case it has no schema - an alternative would be to move the throwing behaviour to fetch rather @caridy?

justinbmeyer · 2014-12-23T16:19:24Z

test/loader/amd.js

@@ -1,4 +1,4 @@
-define(['./amd-dep'], function(dep) {
+define(['./amd-dep.js'], function(dep) {


Is the .js mandatory in AMD?

This is a tough one actually - most AMD doesn't use extensions, so we could still have the AMD layer itself add the extension. In CommonJS we could do something similar assuming the extension is optional. I'm not sure about this though.

guybedford · 2015-03-03T13:31:24Z

This has been replaced by #317.

guybedford force-pushed the master branch 2 times, most recently from d4e2166 to 572ace0 Compare September 25, 2014 18:11

guybedford mentioned this pull request Sep 26, 2014

Load css modules without exclamation mark in the name systemjs/systemjs#194

Closed

guybedford force-pushed the master branch 2 times, most recently from 875d923 to 9d5c7b1 Compare September 26, 2014 11:08

guybedford force-pushed the master branch from 8053538 to 0f4d801 Compare September 29, 2014 10:01

disable auto js extensions

0a59971

guybedford force-pushed the js branch from ace2e3a to 0a59971 Compare September 30, 2014 10:47

guybedford reviewed Sep 30, 2014
View reviewed changes

throw if no URI schema in locate, use file: in Node

5c39a92

guybedford mentioned this pull request Oct 3, 2014

Update loader module name resolver google/traceur-compiler#1221

Open

arv reviewed Oct 3, 2014
View reviewed changes

guybedford force-pushed the master branch 5 times, most recently from 19921ce to cc53028 Compare November 18, 2014 13:52

guybedford force-pushed the master branch from b2f0a0d to e439d57 Compare December 23, 2014 13:06

guybedford mentioned this pull request Dec 23, 2014

A JSON format? systemjs/systemjs#277

Closed

justinbmeyer reviewed Dec 23, 2014
View reviewed changes

guybedford mentioned this pull request Jan 19, 2015

config.js: Problem with package name path to lib directory and bundling jspm/jspm#408

Closed

guybedford force-pushed the master branch 9 times, most recently from ceb8afb to f98b78d Compare January 28, 2015 12:28

guybedford closed this Mar 3, 2015

guybedford deleted the js branch April 2, 2015 15:40

		@@ -1,4 +1,4 @@
		define(['./amd-dep'], function(dep) {
		define(['./amd-dep.js'], function(dep) {

disable auto js extensions #219

disable auto js extensions #219

Uh oh!

Conversation

guybedford commented Sep 24, 2014

Uh oh!

guybedford commented Sep 24, 2014

Uh oh!

caridy commented Sep 28, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guybedford commented Sep 30, 2014

Uh oh!

caridy commented Sep 30, 2014

Uh oh!

guybedford commented Sep 30, 2014

Uh oh!

caridy commented Sep 30, 2014

Uh oh!

guybedford commented Oct 1, 2014

Uh oh!

guybedford commented Oct 1, 2014

Uh oh!

caridy commented Oct 1, 2014

Uh oh!

guybedford commented Oct 1, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guybedford commented Mar 3, 2015

Uh oh!

Uh oh!